Allow local mods to be searched, default sort by highest dps and fix influences mods.#5375
Closed
QuickStick123 wants to merge 38 commits into
Closed
Conversation
This was referenced Dec 23, 2022
…minimum weight to 0.5 as it seems to be minimum we can get away with on some builds
…d to re export everything.
QuickStick123
force-pushed
the
local-mod-support-and-default-sort-mods
branch
from
d11100f to
59acccf
Compare
QuickStick123
changed the title
QuickStick123
force-pushed
the
local-mod-support-and-default-sort-mods
branch
from
a18ec33 to
78c6e82
Compare
QuickStick123
force-pushed
the
local-mod-support-and-default-sort-mods
branch
from
76a4379 to
69193c0
Compare
3 tasks
3 tasks
2 tasks
Contributor
Author
|
Closing as won't be fixing merge conflicts here as well, just use #5735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5364 #5448
Description of the problem being solved:
Local mods aren't currently supported
Results weren't automatically sorted by full dps this was an option you could turn on but due to having to research it was hard to tell if it worked and should be the default behaviour tbh especially if we are dealing with inaccurate searches from not knowing base info which this patch allows.
Minimum weight is reduced significantly to help include more results in the search as they are now significantly less accurate this might create problems so would need testing to see if we hit the 10k item cap that starts causing problems.
Add mediocre support for flasks if flask isn't enabled it won't work base obviously don't work and effect does nothing cause their are no mods to scale.
Fix up influence mods and a couple other missing mods in the trader and in general. This was done by adding a new tag to the exporter as it seems influence items only use one flag for their given influence. e.g. influence "sword" will only apply to swords and not two hands which use "2h_sword" for their influence prefix. I had a good look at trying to find a way to apply this automatically but this solution was the easiest to maintain I could come up with.
Only search a similarly usable weapon. This does mean people using sceptres can't see wand / rune dagger potential upgrades which isn't ideal but it is overall more robust say some one was using a claw attack skill and swords are the best weight then they won't waste their search.
Fixes bug where import item isn't updated when sorting.
Fixes bug where full dps doesn't work with item sorting
Changes dps sorting to by default not include enchants with a toggle to re-enable them. This is because generally you will anoint an item for significantly less than the cost of dps difference. Expect in the case of helmet enchants.
This should be carefully considered as it could cause a lot of unwanted confusion it should be strongly considered removing this and picking a default behaviour.