PoB Trader: add dynamic sorting and fall back from price sorting#5500
Merged
LocalIdentity merged 4 commits intoJan 2, 2023
Merged
Conversation
Contributor
|
Going to have a lot of merge conflicts with #5375 |
Dullson
force-pushed
the
pobtrader_sorting_improvement
branch
from
bb28a37 to
2a5fa58
Compare
LocalIdentity
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two features:
Price sorting checks and fallback
Current price-related sorting modes depend upon poe.ninja data which is only available for PC leagues. And it's patchy at the league start even for those.
This PR has some modifications to allow the pricing process to fail gracefully regardless of realm or league and fall back to default DPS sorting if the price data is inadequate.
Poe.ninja price fetching is also disabled for console leagues, preventing redundant requests.
Dynamic sorting update
Currently, changing the sorting mode does nothing for already-fetched items and only affects future searches. This felt like a poor user experience since we provide no feedback on the sorting switch interaction.
This PR changes the behavior of the switch dropdown to also update the sorting order of already fetched items.