"Trade for items" feature (one handed weapon) doesn't take into account "1% increased damage per 15 strength" mod on amulet

[melink14]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

In general, it seems that the generated mod weights take into account global state of my character so I would also expect it to know that strength gives me increased damage.

How does Path of Building behave?

The list of generated weights is missing strength as a damage mod despite it being enough to change the order of the results when sorting by weighted sum.

How to reproduce the issue

1. Import build
2. Trade for new sceptre.
3. Notice that weapons with strength are not sorted as highly as they should.

Results might not be the same but here's example showing no strength in search (https://www.pathofexile.com/trade/search/Sanctum/r7kMQjZiQ). See screenshot for example where order was wrong due to it not being taken into account.

Character build code

https://pobb.in/p7LqLc8hGAo6

Screenshots

[QuickStick123]

This is impossible to fix sorry we have run out of mods we can search for otherwise we hit search complexity limit. For example the int gem mod gives around 0.7% and 55 strength roll would be about 0.6%. Everything else would obviously give more.


Some synth mods seem to be leaking in even when it is turned off which should be fixed in an upcoming patch but there isn't really anything we can do here.

[melink14]

Seems fair. I was just surprised when the lower ranked item gave more damage in PoB.

To the complexity point, there are several higher weighted irrelevant mods which I have to manually remove now that could make room for a more complete list but priority shouldn't be high for such marginal gains.

[QuickStick123]

There is a sorting option (basically re-ranks items based upon testing their impact on your build not item weight) here that should fix that. There is currently a bug with that search option not using full dps but it will be the default and be fixed in #5375