PoB Trader: Fix issues caused by sorting mode change#5552
Merged
LocalIdentity merged 4 commits intoFeb 18, 2023
Conversation
Contributor
|
I also included a fix fir the import button in #5375 but this seems to fix it differently. |
QuickStick123
added
bug
Dullson
commented
Jan 5, 2023
| end | ||
|
|
||
| self.sortedResultTbl[index] = sortedItems | ||
| self.itemIndexTbl[index] = 1 |
Contributor
Author
There was a problem hiding this comment.
I also included a fix fir the import button in #5375 but this seems to fix it differently.
Didn't check that PR yet but this line was wrong and had to be fixed. Looks like the intention was to reset the item index to 1 after sorting because dropdowns reset but the sorted item indexes are a little more convoluted. This is the correct way to reference the item on the first slot of dropdown containing sorted items.
Contributor
|
|
Contributor
Author
|
Now it should fix #5544 |
LocalIdentity
approved these changes
Feb 18, 2023
Dullson
added a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…ommunity#5552) * fix(pobtrader): error message not clearing after successful sorting * fix(pobtrader): sort dropdown throwing error for jewels * fix(pobtrader): import button item tooltip not updating on sort * fix(pobtrader): check pseudoMods before indexing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5542, #5544
Description of the problems being solved:
Import Itembutton tooltip not displaying selected dropdown item after sorting