Promote RouteAdvertisements feature gate to default feature set#2225
Conversation
|
/hold |
|
Hello @jcaamano! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
do-not-merge/hold
|
/retitle Promote RouteAdvertisements feature gate to default feature set Retitling for consistency/searchability in the future |
openshift-ci
Bot
changed the title
|
/test ? |
|
@jcaamano: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
/cc |
openshift-merge-robot
removed
the
needs-rebase
This feature only targets metal |
It seems like the tooling is picking up results from jobs that should not be running these tests. The problem is that the test itself fails for unrelated reason before it has the chance to check if it should be skipped or not. Discussed on slack |
Most of the flakes are due to reasons unrelated to the feature: has flaked three times All of them are due to https://issues.redhat.com/browse/OCPBUGS-56488, unrelated to this feature.
Unlikely to get 95% pass rate until the root cause is fixed. flaked once failed once flaked 4 times. 3 of those were due to what was fixed with openshift/origin#29803 however the fix did only take effect recently because no CI builds were being accepted for most of last week The other one is also due to OCPBUGS-56488. |
|
/test ci/prow/verify-feature-promotion |
|
@JoelSpeed: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test verify-feature-promotion |
1 similar comment
|
/test verify-feature-promotion |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
openshift-merge-robot
removed
the
needs-rebase
|
/test verify-feature-promotion |
|
/retest |
|
/override ci/prow/verify-crd-schema Existing issues that cannot be resolved now /override ci/prow/verify-feature-promotion This feature is only applicable to the metal platform and is only being tested on dual stack due to limitations in CI capacity (though there are single stack specific tests). Per the latest results only a single test is showing below 95%, however, this test was renamed and the new name shows at least 95% over the last 7 days. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Waiting for a couple of hours to sync with the whole team |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/override ci/prow/verify-crd-schema Existing issues that cannot be resolved now /override ci/prow/verify-feature-promotion This feature is only applicable to the metal platform and is only being tested on dual stack due to limitations in CI capacity (though there are single stack specific tests). |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 017e9dd
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
7 participants
No description provided.