[release-4.19] CORENET-6148: Promote RouteAdvertisements feature gate to default feature set by arghosh93 · Pull Request #2425 · openshift/api

arghosh93 · 2025-07-28T10:44:17Z

This PR lifts the FG for RouteAdvertisements feature.

RouteAdvertisements feature gate was lifted in 4.20 via below PR:
#2225

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>

openshift-ci-robot · 2025-07-28T10:44:21Z

@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

Details

In response to this:

This PR lifts the FG for RouteAdvertisements feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-07-28T10:44:23Z

Hello @arghosh93! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed · 2025-07-28T11:02:20Z

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

openshift-ci · 2025-07-28T11:03:46Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

Details

In response to this:

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tssurya · 2025-07-28T11:54:47Z

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

yea will open a SBAR and link it here.

openshift-ci-robot · 2025-07-28T12:34:16Z

@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

Details

In response to this:

This PR lifts the FG for RouteAdvertisements feature.

RouteAdvertisements feature gate was lifted in 4.20 via below PR:
#2225

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arghosh93 · 2025-07-28T15:16:22Z

/hold
Till we are working on the SBAR.

sdodson · 2025-08-04T13:54:03Z

/test verify-feature-promotion

tssurya · 2025-08-08T18:22:57Z

/test verify-feature-promotion

tssurya · 2025-08-11T09:19:54Z

/test verify-feature-promotion

jcaamano · 2025-08-13T09:01:34Z

/test verify-feature-promotion

tssurya · 2025-08-14T11:01:05Z

/test verify-feature-promotion

jcaamano · 2025-08-14T11:13:07Z

@JoelSpeed I think these numbers do not add up

error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over a VRF-Lite configuration Pods should be able to communicate on a secondary network [Timeout:30m] [Suite:openshift/conformance/parallel]" only has 13 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 External host should be able to query route advertised pods by the pod IP [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 Pods should communicate with external host without being SNATed [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}

They run daily and they have been running for more than 14 days. What are we missing?

JoelSpeed · 2025-08-14T11:15:58Z

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

jcaamano · 2025-08-14T16:29:05Z

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

It's strange though that it just happens to those particular test cases if entire jobs failed to run. Will run gangway as you suggested, thanks.

tssurya · 2025-08-18T18:07:02Z

/test verify-feature-promotion

tssurya · 2025-08-19T07:09:51Z

error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [EgressIP] Advertising EgressIP [apigroup:user.openshift.io][apigroup:security.openshift.io] For the default network Pods should have the assigned EgressIPs and EgressIPs can be created, updated and deleted [apigroup:route.openshift.io] When the network is IPv4 [Suite:openshift/conformance/parallel]" only passed 94%, need at least 95% for "RouteAdvertisements" on {metal amd64 ha dual}

@jcaamano we are almost there.

tssurya · 2025-08-19T07:11:23Z

/test verify-feature-promotion

jcaamano · 2025-08-20T08:12:43Z

/test verify-feature-promotion

tssurya · 2025-08-20T08:24:54Z

The verify lane is looking much better. The tests are at the correct pass rate above 95% on the dualstack lanes we have.

error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {metal amd64 ha ipv4}
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {metal amd64 ha ipv6}
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {aws amd64 ha }
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {azure amd64 ha }
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {gcp amd64 ha }
F0820 08:20:22.479751   10369 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {vsphere amd64 ha }

It's failing for platform reasons. Is this something you can override @JoelSpeed or do we need to do anything on our side.

As for the SBAR: I had opened it 20 days ago: https://docs.google.com/presentation/d/1Ak0bkXFkvoY8JxipMQGct8uCWroPNc84V64PjmXFyek/edit?slide=id.g9814768380_0_0#slide=id.g9814768380_0_0 haven't heard back though @davegord is helping me get some eyes on this.

tssurya · 2025-08-20T09:13:34Z

/hold

please don't remove hold (@jcaamano will do it once we are ready on ovnk/cno side fully) we are only trying to ensure we get this PR to a ready state in parallel.

arghosh93 · 2025-08-26T04:19:07Z

/test verify-feature-promotion

tssurya · 2025-09-01T08:38:39Z

@JoelSpeed : PTAL, we are trying to graduate this feature some time this week. All development PRs have been backported into 4.19 already. I have gotten OCP leadership ACK on SBAR, we are waiting on the BU ack still which I will let you know as soon as we hear back.

JoelSpeed · 2025-09-01T10:48:05Z

Changes LGTM, ping when you have the BU ack and I'll get it tagged

JoelSpeed · 2025-09-02T14:07:08Z

SBAR now has the appropriate approvals

/lgtm
/override ci/prow/verify-feature-promotion
/label backport-risk-assessed
/label jira/valid-bug

openshift-ci · 2025-09-02T14:07:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghosh93, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-09-02T14:07:50Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

Details

In response to this:

SBAR now has the appropriate approvals

/lgtm
/override ci/prow/verify-feature-promotion
/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2025-09-02T14:36:43Z

/verified by ci/prow/verify-feature-promotion

openshift-ci-robot · 2025-09-02T14:36:57Z

@JoelSpeed: This PR has been marked as verified by [ci/prow/verify-feature-promotion](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2425/pull-ci-openshift-api-release-4.19-verify-feature-promotion/1960195290258477056).

Details

In response to this:

/verified by ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed · 2025-09-02T14:37:17Z

/hold cancel

SBAR has been approved

openshift-ci-robot · 2025-09-02T15:15:40Z

/retest-required

Remaining retests: 0 against base HEAD 1c614f5 and 2 for PR HEAD d68a59c in total

openshift-ci-robot · 2025-09-02T16:14:25Z

/retest-required

Remaining retests: 0 against base HEAD 1c614f5 and 2 for PR HEAD d68a59c in total

arghosh93 · 2025-09-02T18:04:48Z

/retest-required

tssurya · 2025-09-02T18:48:45Z

/test verify-crd-schema

hmm this seems red for reasons not related to this PR? is this something we need to fix as FUP? @JoelSpeed ?

----- SCHEMACHECK -----
ERROR: ConditionsMustHaveProperSSATags: crd/networks.operator.openshift.io version/v1 field/^.status.condition must define valid condition properties: observedGeneration attribute is missing
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.useMultiNetworkPolicy may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.migration.features.egressFirewall may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.migration.features.egressIP may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.migration.features.multicast may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.defaultNetwork.openshiftSDNConfig.useExternalOpenvswitch may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.defaultNetwork.openshiftSDNConfig.enableUnidling may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.defaultNetwork.ovnKubernetesConfig.gatewayConfig.routingViaHost may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.deployKubeProxy may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.disableNetworkDiagnostics may not be a boolean
ERROR: NoBools: crd/networks.operator.openshift.io version/v1 field/^.spec.disableMultiNetwork may not be a boolean
ERROR: NoMaps: crd/networks.operator.openshift.io version/v1 field/^.spec.kubeProxyConfig.proxyArguments may not be a map

maybe we need a bug for this?

everettraven · 2025-09-02T19:07:15Z

@tssurya I saw that Joel overrode the verify-crd-schema check previously: #2425 (comment)

Overriding for same reasons.

/override ci/prow/verify-crd-schema

openshift-ci · 2025-09-02T19:07:28Z

@everettraven: everettraven unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

@tssurya I saw that Joel overrode the verify-crd-schema check previously: #2425 (comment)

Overriding for same reasons.

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knobunc · 2025-09-02T19:28:54Z

/override ci/prow/verify-crd-schema

openshift-ci · 2025-09-02T19:29:37Z

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/verify-crd-schema

Details

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-09-02T21:11:35Z

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`d68a59c`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/verify-crd-schema	`d68a59c`	link	true	`/test verify-crd-schema`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Lift 4.19 feature gate for RouteAdvertisements

d68a59c

Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 28, 2025

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 28, 2025

openshift-ci Bot requested review from JoelSpeed and everettraven July 28, 2025 10:44

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2025

openshift-ci Bot assigned gangwgr, wangke19, xingxingxia and JoelSpeed Sep 2, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2025

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 2, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2025

openshift-merge-bot Bot merged commit c9f500d into openshift:release-4.19 Sep 2, 2025
24 of 25 checks passed

tssurya mentioned this pull request Sep 3, 2025

OCPBUGS-61185: Consume latest OCP API in 4.19 openshift/cluster-network-operator#2790

Merged

Conversation

arghosh93 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 28, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 28, 2025

Uh oh!

JoelSpeed commented Jul 28, 2025

Uh oh!

openshift-ci Bot commented Jul 28, 2025

Uh oh!

tssurya commented Jul 28, 2025

Uh oh!

openshift-ci-robot commented Jul 28, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arghosh93 commented Jul 28, 2025

Uh oh!

sdodson commented Aug 4, 2025

Uh oh!

tssurya commented Aug 8, 2025

Uh oh!

tssurya commented Aug 11, 2025

Uh oh!

jcaamano commented Aug 13, 2025

Uh oh!

tssurya commented Aug 14, 2025

Uh oh!

jcaamano commented Aug 14, 2025

Uh oh!

JoelSpeed commented Aug 14, 2025

Uh oh!

jcaamano commented Aug 14, 2025

Uh oh!

tssurya commented Aug 18, 2025

Uh oh!

tssurya commented Aug 19, 2025

Uh oh!

tssurya commented Aug 19, 2025

Uh oh!

jcaamano commented Aug 20, 2025

Uh oh!

tssurya commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tssurya commented Aug 20, 2025

Uh oh!

arghosh93 commented Aug 26, 2025

Uh oh!

tssurya commented Sep 1, 2025

Uh oh!

JoelSpeed commented Sep 1, 2025

Uh oh!

JoelSpeed commented Sep 2, 2025

Uh oh!

openshift-ci Bot commented Sep 2, 2025

Uh oh!

openshift-ci Bot commented Sep 2, 2025

Uh oh!

JoelSpeed commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 2, 2025

Uh oh!

JoelSpeed commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 2, 2025

Uh oh!

openshift-ci-robot commented Sep 2, 2025

Uh oh!

arghosh93 commented Sep 2, 2025

Uh oh!

tssurya commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

everettraven commented Sep 2, 2025

Uh oh!

openshift-ci Bot commented Sep 2, 2025

Uh oh!

arghosh93 commented Jul 28, 2025 •

edited

Loading

openshift-ci-robot commented Jul 28, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jul 28, 2025 •

edited by openshift-ci Bot

Loading

tssurya commented Aug 20, 2025 •

edited

Loading

tssurya commented Sep 2, 2025 •

edited

Loading