Skip to content

Share link creation via bottom sheet for files in OCFileList#2747

Merged
AndyScherzinger merged 1 commit intomasterfrom
bottomSheetFileShareLink
Jun 28, 2018
Merged

Share link creation via bottom sheet for files in OCFileList#2747
AndyScherzinger merged 1 commit intomasterfrom
bottomSheetFileShareLink

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

see $subject, atm this is for files only, roadmap is #2485

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5c203f3). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #2747   +/-   ##
========================================
  Coverage          ?   6.38%           
========================================
  Files             ?     295           
  Lines             ?   29579           
  Branches          ?    4283           
========================================
  Hits              ?    1889           
  Misses            ?   27403           
  Partials          ?     287
Impacted Files Coverage Δ
...cloud/android/ui/helpers/FileOperationsHelper.java 0% <0%> (ø)
...om/owncloud/android/ui/dialog/SendShareDialog.java 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø)

@tobiasKaminsky
Copy link
Copy Markdown
Member

tobiasKaminsky commented Jun 22, 2018

👍
Cool :-)

Approved with PullApprove

@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch 4 times, most recently from 4d6b7c1 to 0a50db1 Compare June 27, 2018 06:54
@nextcloud nextcloud deleted a comment Jun 27, 2018
@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch 2 times, most recently from 6cd1eaa to 7cec873 Compare June 27, 2018 12:40
@mario
Copy link
Copy Markdown
Contributor

mario commented Jun 28, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger force-pushed the bottomSheetFileShareLink branch from 7cec873 to 0745348 Compare June 28, 2018 08:44
@AndyScherzinger AndyScherzinger merged commit 1ddd0a2 into master Jun 28, 2018
@AndyScherzinger AndyScherzinger deleted the bottomSheetFileShareLink branch June 28, 2018 08:51
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants