Roadmap: file detail & new sharing

[tobiasKaminsky]

During hackweek @jancborchardt draw a new sharing system, which is nearly the same as web UI and which should then be also in sync with iOS.

• Iteration 1 for File detail & new sharing Iteration 1 for file detail & new sharing  #2533 (revamped UI approach)
• Iteration 2 for File detail & new sharing Iteration 2 for file detail & new sharing  #2573 (sharing in general)
• Iteration 3 for File detail & new sharing Iteration 3 for file detail & new sharing #2671 (e-mail sharing permissions, details)
• Iteration 4 for File detail & new sharing Iteration 4 for File detail & new sharing - email share #2700 (create e-mail shares)
• Iteration 5 for File detail & new sharing Iteration 5 for File detail & new sharing - Comments #2690 (comments)
• Display copy icon and adding send action to the link menu Display copy icon and adding send action to the link menu #2730
• Share link creation via bottom sheet for files in OCFileList Share link creation via bottom sheet for files in OCFileList #2747
• implement Improve share link handling #2742
• Add label/tag support - Support for viewing tags #11515
• Remove legacy sharing screen completely - TBD

Enhanced file detail view:

This is an enhanced view for images/videos which have a preview:

• no overflow menu on top, but next to filename
• clicking on star toggles favorite
• tags opens up editing
• activity and sharing as "tabs" which can be toggled

Activity tab:

• combined activity, comments, versions (endpoint on server side is needed for this, 📑 Sidebar: combine file Activity and Comments into »Activity« timeline tab (possibly also "Versions") server#658)
• on top: text input box for commenting

Share tab:

• sharees are sorted by permissions (from max permissions to read only)
• on each sharee there is an overflow menu with its specific sharing permissions

Sharing to a new user/group/link:

• click on text input on share tab hides activity/sharing toggle to have more space for actually searching
• share link as entry beneath search field
  • with "can edit"
  • click on it opens up existing app chooser to receive link
• during input we show the list of results
  • username
  • group
  • federated sharing
  • share by mail

• share (left) -> opens up share dialog of file detail
• link (right) -> directly creates read-only link (if needed) and open list with apps to send to. "copy link" should be first entry as otherwise users might not find it (@schiessle)

cc: @rullzer @marinofaggiana for other clients

This is an overview issue, where I will link each PRs into it.
My plan is to do this step by step, so that each PR is rather small.

Of course any feedback is welcome :-)

[tobiasKaminsky]

Ref for comments/sharing: nextcloud/server#7315 (comment)

[AndyScherzinger]

So how would this be combined with commenting if we ever implemented commenting on files in the client?

[tobiasKaminsky]

Comments will shown in the activity tab, sorted by time, with version changes and other activities.
If you want to comment a file, a text input is always shown (see very first picture with "nice picture" and "right arrow").

[AndyScherzinger]

Hmmm, commenting is like chatting so I'd expect the commenting part on the very bottom tbh

[tobiasKaminsky]

This is true for every regular chat app, but then the chat is also sorted from top (old) -> bottom (new).
On this mockup (and web UI) all "events" (activities, version info, comments) are sorted from new (top) -> old (bottom), so then the comment input field should also be on top, as the string, which was recently inserted will also be on top.

[tobiasKaminsky]

Current master:

[AndyScherzinger]

So will the current (webUI) master also merge activities and comments?

[tobiasKaminsky]

Yes, as mentioned above this is in issue nextcloud/server#658

[AndyScherzinger]

@tobiasKaminsky how will this look for now-previewable files?

[AndyScherzinger]

@tobiasKaminsky never mind, looked at the web ui and again... I need to ask and I feel have to phrase the question exactly like this to make a point:
Why is there a pen&paper mock-up when it is basically "please implement it exactly like the web ui"?

[AndyScherzinger]

This is a (web)screenshot with the elements added...

So how "Android native" does this feel for you?

cc @tobiasKaminsky @mario