Cleanup enemy export and config tab#5699
Merged
LocalIdentity merged 5 commits intoMar 1, 2023
Merged
Conversation
Contributor
|
Don't know if the pen changes were in this or the previous one but I think 3% is enough to effectively consider closing #4741 |
Member
Author
LocalIdentity
approved these changes
Mar 1, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* initial cleanup * generate ordered boss skill list on export * add evasion colours * move shaper balls over from old method * move atziri from old method and apply more damage to uber
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the export of boss data (from #5620 and #5612), as well as moves the "enemyIsBossTooltip" into data.lua
Both the bosses data itself, as well as the skills used by the bosses are done via 1 export script instead of separately
It also generates the ordered boss skill list on export in the order the skills show up in the template file
The
enemyIsBossTooltipis updated with the new chaos mix/pen values, as well as having the armour and evasion multipliers in there from the boss data, it also is updated automatically based on values in data.lua rather than having to be manually updatedit is possible I could make it a tooltip func and only show the valid data for that type, but it is small enough that this should be unnecessary