Add new boss skills, auto apply uber changes if set to uber, and update non-uber pen/chaos mix#5612
Merged
LocalIdentity merged 32 commits intoFeb 19, 2023
Conversation
Contributor
QuickStick123
left a comment
QuickStick123
left a comment
There was a problem hiding this comment.
Overall looks good there were a couple other issues I noticed as if no boss is selected the boss skill preset seems to be scaled down a lot. Not sure if this is intended. I also noticed a weird snapshotting issue with the placeholders but this is not introduced in this PR and is in master so not a big deal.
| build.configTab.varControls['enemyDamageType'].enabled = true | ||
| end | ||
| end }, | ||
| { var = "enemyDamageRollRange", type = "integer", label = "Enemy Skill Roll Range %:", ifFlag = "BossSkillActive", tooltip = "The percentage of the roll range the enemy hits for \n eg at 100% the enemy deals its maximum damage", defaultPlaceholderState = 70, hideIfInvalid = true }, |
Contributor
There was a problem hiding this comment.
This would be better as a slider but would require a bit more work to implement them in the config tab.
LocalIdentity
approved these changes
Feb 19, 2023
1 task
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…te non-uber pen/chaos mix (PathOfBuildingCommunity#5612) * add new boss skills, auto apply uber changes, and update non-uber pen * fix spell * update how boss data is handled * move boss skill list to data and update multiplier name * move tooltip into data * actually commit data change * fix spelling * update atziri flameblast to include non-uber variant * move tooltip to a tooltip func to only show relevant info for that skill * make rollrange configurable * fix spelling * fix spelling * add option to always hide config option even if invalid * remove redundant logic * move boss skills to a separate file * fixes tooltip inconsistency * add minor suggestions * initial export implementation * fix indexing issue * fix colour code crash * export boss data * fix damage spread * export some skill stats * export more values and cleanup functions * export damages * apply rarity multiplier * fix spelling * fix spelling * revert to using old hardcoded values to better match poeDB * update multipliers * fix uber mult
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 new boss skills that have been requested a bunch, elder slam, exarch ball, eater beam, maven fireball, and sirus meteor as well as now automatically applying some of the uber variant changes (like shaper ball pen and extra damage) when set to uber
This also updates the penetration and chaos mix for non-uber settings, this is done due to pen being very rare and punishing high max res characters too much, you can still manually apply the penetration (or will be applied if a boss skill with pen is selected)
The chaos mix is updated due to newer content having more chaos damage than in the old days, so its been bumped up from 25% of the damage the other types do to 40%