Fix all Copilot review suggestions from Batches 4/7/10#387
Merged
Conversation
Fixes from PR #368 (Batch 4): 1. UpdateInfoEventArgs: make VersionRespDTO nullable to avoid null ref 2. ClientUpdateStrategy: build VersionInfo list from DownloadAssets instead of passing empty list to ProcessInfo constructor 3. ClientUpdateStrategy: use injected _orchestrator if available, fall back to creating one with HttpClient 5. DefaultDownloadOrchestrator: ensure destDir exists (Directory.CreateDirectory) and dispose SemaphoreSlim (using) 6. DownloadPlanBuilder: guard against invalid currentVersion string Fixes from PR #380 (Batch 10): 8. OSSUpdateStrategy: set zip filename to match Decompress() expectations 9. OSSUpdateStrategy: throw clear exception when URL is null/empty 10. OSSUpdateStrategy: set HttpClient.Timeout to 60s to match old behavior Closes #386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 10 actionable Copilot review comments from PRs #368, #374, #380.
Fixes
#1 UpdateInfoEventArgs — Make VersionRespDTO nullable
#2 ProcessInfo empty list — Build VersionInfo list from DownloadAssets instead of passing empty list
#3 Injected orchestrator — Use _orchestrator if available, fall back to new HttpClient+DefaultDownloadOrchestrator
#5 destDir + SemaphoreSlim — Directory.CreateDirectory + using var sem
#6 Null version guard — DownloadPlanBuilder returns DownloadPlan.Empty for invalid currentVersion
#8 OSS filename — Set zip filename to match Decompress() expectations
#9 OSS URL validation — Throw clear exception when URL is null/empty
#10 OSS timeout — Set HttpClient.Timeout to 60s to match old DownloadManager behavior
Build + Tests
Closes #386