Batch 7: Extension points + configuration completion#374
Merged
Conversation
- Add DownloadOrchestrator<T>() extension point to AbstractBootstrap - Add DiffMode option to UpdateOptions (Serial default) - Note ICleanStrategy/IDirtyStrategy placeholders for cross-project ref Closes #373
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes a couple of planned configuration/extension “hooks” in GeneralUpdate.Core by adding a new bootstrap extension point for download orchestration and exposing a new DiffMode update option.
Changes:
- Added
UpdateOptions.DiffModewith a default ofSerial. - Added
AbstractBootstrap.DownloadOrchestrator<T>()extension point (plus placeholders for future strategy extension points).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/c#/GeneralUpdate.Core/Configuration/UpdateOptions.cs | Adds the DiffMode configuration option constant. |
| src/c#/GeneralUpdate.Core/Configuration/AbstractBootstrap.cs | Adds a download orchestrator registration extension point. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+85
to
+86
| public TBootstrap DownloadOrchestrator<T>() where T : Download.Abstractions.IDownloadOrchestrator, new() | ||
| { _extensions[typeof(Download.Abstractions.IDownloadOrchestrator)] = typeof(T); return (TBootstrap)this; } |
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing extension point and configuration options.
Changes
AbstractBootstrap
UpdateOptions
Build
Closes #373