Merged
Conversation
- Fix service file generation in ServiceManager: * Change Type=forking to Type=notify for better PostgreSQL integration * Add missing PostgreSQL options (-k socket directory, -p port) * Add proper ExecStop command for graceful shutdown * Increase timeouts from 0 to 120 seconds for proper startup/shutdown - Fix CLI commands to use service-aware methods: * start command now uses startInstanceWithService() * stop command now uses stopInstanceWithService() * restart command updated to use service-aware methods - Update restartInstance() to be service-aware * Now uses service-aware stop/start methods for consistency These changes ensure PostgreSQL instances with enabled services: - Properly autostart after system restart via systemd - Use consistent service management for manual operations - Have proper systemd service configuration Fixes #52 Co-authored-by: Samuel <xar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pgforge service autostart issue where enabled services wouldn't start after system restart.
Changes
Testing
pgforge enable-service <instance>pgforge service-status <instance>Fixes #52
Generated with Claude Code