Add validation for accept request and reply#902
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 8, 2026
Merged
Conversation
ejohnstown
previously approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stricter validation around SSH service negotiation messages to ensure that only the expected ssh-userauth service is accepted during the service request/accept phase (Fixes F-604).
Changes:
- Validate incoming
MSGID_SERVICE_REQUESTservice name againstssh-userauthand disconnect when unsupported. - Validate incoming
MSGID_SERVICE_ACCEPTservice name againstssh-userauthand fail when unexpected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
force-pushed
the
request-validation
branch
from
51f23aa to
e69bdab
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #902
Scan targets checked: wolfssh-bugs, wolfssh-compliance, wolfssh-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
padelsbach
force-pushed
the
request-validation
branch
from
e69bdab to
ffa646a
Compare
ejohnstown
approved these changes
Apr 7, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-604