Skip to content

[ShadyDOM] Adds element(s)FromPoint to document and shadowRoot#463

Merged
sorvell merged 9 commits intomasterfrom
elementFromPoint
Jul 29, 2021
Merged

[ShadyDOM] Adds element(s)FromPoint to document and shadowRoot#463
sorvell merged 9 commits intomasterfrom
elementFromPoint

Conversation

@sorvell
Copy link
Copy Markdown
Collaborator

@sorvell sorvell commented Jul 28, 2021

Fixes #461.
Fixes #69.

Copy link
Copy Markdown
Collaborator

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, algorithm makes sense afaict.

Copy link
Copy Markdown
Collaborator

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like IE/old Edge tests are failing due to elementsFromPoint being prefixed to msElementsFromPoint:

Copy link
Copy Markdown
Collaborator

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorvell sorvell merged commit 88c937a into master Jul 29, 2021
@sorvell sorvell deleted the elementFromPoint branch July 29, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ShadyDOM] Add support for element(s)FromPoint [ShadyDOM] shadowRoot.elementFromPoint is undefined when using Selenium and Firefox

3 participants