Conversation
… of `window`, polyfill installation breaks.
bicknellr
requested review from
kevinpschaaf and
sorvell
and removed request for
aomarks
| // In Firefox 33, `EventTarget` exists, but `EventTarget.prototype` is not | ||
| // in the prototype chain of `window` and, strangely, | ||
| // `window instanceof EventTarget` still returns true. | ||
| if (window[NATIVE_PREFIX + 'addEventListener'] === undefined) { |
Collaborator
There was a problem hiding this comment.
Does EventTarget exist in Node.prototype? (the else clause also deals with patching Node up)
Collaborator
Author
There was a problem hiding this comment.
Yes, Node seems to be set up correctly:
Collaborator
There was a problem hiding this comment.
Ok, thanks for checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 33 has
EventTarget, butEventTarget.prototypeis not in the prototype chain ofwindow. Currently, ifEventTargetexists, then the__shady_native_-prefixed functions are only added toEventTarget.prototype. In Firefox 33, this causes the polyfills to throw when a call to one of these functions onwindowis attempted later during startup.Tested as http://cl/351475102 .