Skip to content

[WIP] Re-shaping the canonical variant array to support more general …#7494

Draft
AdamGS wants to merge 13 commits intodevelopfrom
adamg/variant-array
Draft

[WIP] Re-shaping the canonical variant array to support more general …#7494
AdamGS wants to merge 13 commits intodevelopfrom
adamg/variant-array

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 16, 2026

No description provided.

@AdamGS AdamGS force-pushed the adamg/variant-array branch 2 times, most recently from 3630cef to 5e6dd39 Compare April 16, 2026 19:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026

Merging this PR will degrade performance by 24.96%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 26 improved benchmarks
❌ 1 regressed benchmark
✅ 1171 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime dynamic_dispatch_f32[10M] 165.9 µs 113.7 µs +45.95%
Simulation take_search[(0.005, 0.05)] 167.5 µs 131.1 µs +27.79%
Simulation take_search[(0.005, 0.5)] 1.5 ms 1.2 ms +31.03%
Simulation take_search[(0.005, 0.1)] 319.7 µs 246.9 µs +29.5%
Simulation take_search[(0.005, 1.0)] 3.1 ms 2.3 ms +31.25%
Simulation take_search[(0.01, 0.05)] 178.7 µs 142.2 µs +25.61%
Simulation take_search[(0.01, 0.1)] 340.6 µs 267.8 µs +27.2%
Simulation take_search[(0.01, 0.5)] 1.6 ms 1.3 ms +28.57%
Simulation take_search[(0.1, 0.5)] 2.2 ms 1.8 ms +20.42%
Simulation take_search[(0.01, 1.0)] 3.3 ms 2.5 ms +28.77%
Simulation take_search_chunked[(0.005, 0.1)] 383.4 µs 321.6 µs +19.22%
Simulation take_search[(0.1, 0.05)] 248.4 µs 212 µs +17.21%
Simulation take_search_chunked[(0.005, 1.0)] 3.7 ms 3.1 ms +20.16%
Simulation take_search_chunked[(0.1, 1.0)] 4.9 ms 4.2 ms +14.62%
Simulation take_search_chunked[(0.01, 0.5)] 2 ms 1.7 ms +18.61%
Simulation take_search_chunked[(0.005, 0.5)] 1.9 ms 1.5 ms +20.05%
Simulation take_search_chunked[(0.1, 0.1)] 518.3 µs 456.3 µs +13.58%
Simulation take_search_chunked[(0.01, 1.0)] 3.9 ms 3.3 ms +18.72%
Simulation take_search[(0.1, 0.1)] 458.1 µs 385.2 µs +18.94%
Simulation take_search_chunked[(0.01, 0.05)] 212.7 µs 181.8 µs +16.98%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing adamg/variant-array (ca552b5) with develop (e2062a7)

Open in CodSpeed

@AdamGS AdamGS force-pushed the adamg/variant-array branch 2 times, most recently from 932cc69 to 330c582 Compare April 21, 2026 16:36
@AdamGS AdamGS added the changelog/feature A new feature label Apr 21, 2026
@AdamGS AdamGS force-pushed the adamg/variant-array branch 4 times, most recently from 4edbac7 to 1289c1e Compare April 24, 2026 10:57
AdamGS added 10 commits April 29, 2026 11:17
…forms of shredding

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-array branch from f97b78e to d927bfd Compare April 29, 2026 10:18
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
Copy link
Copy Markdown
Contributor Author

AdamGS commented Apr 29, 2026

@claude review this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

AdamGS added 2 commits April 29, 2026 15:44
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant