Conversation
Member
Author
fengmk2
force-pushed
the
fix-vp-dev-missing-package-json
branch
2 times, most recently
from
a29953d to
c5293ba
Compare
fengmk2
force-pushed
the
self-upgrade
branch
2 times, most recently
from
220262e to
def89c2
Compare
fengmk2
force-pushed
the
fix-vp-dev-missing-package-json
branch
from
c5293ba to
a612cef
Compare
fengmk2
force-pushed
the
fix-vp-dev-missing-package-json
branch
from
a612cef to
85c0097
Compare
fengmk2
force-pushed
the
fix-vp-dev-missing-package-json
branch
from
78c1988 to
ae90321
Compare
fengmk2
commented
Feb 6, 2026
fengmk2
force-pushed
the
self-upgrade
branch
3 times, most recently
from
787ce1c to
1c3a5e4
Compare
fengmk2
commented
Feb 6, 2026
fengmk2
force-pushed
the
self-upgrade
branch
2 times, most recently
from
48e1dbc to
0c7a539
Compare
Brooooooklyn
approved these changes
Feb 7, 2026
fengmk2
force-pushed
the
fix-vp-dev-missing-package-json
branch
from
ae90321 to
97f4a34
Compare
fengmk2
changed the base branch from
fix-vp-dev-missing-package-json
to
graphite-base/548
fengmk2
force-pushed
the
graphite-base/548
branch
from
97f4a34 to
6529a63
Compare
Implement `vp self-update` (alias: `vp upgrade`) that downloads and installs a new vp CLI version from the npm registry with SHA-512 integrity verification. Features: - Version resolution from npm registry (latest, specific version, or dist-tag) - Parallel download of platform binary + main JS package tarballs - SHA-512 SRI integrity verification for both tarballs - Atomic symlink swap on Unix, junction swap on Windows - Production dependency installation via new binary - Shim refresh after update - Automatic cleanup of old versions (keeps 5 most recent) - `--check` flag to check for updates without installing - `--rollback` to revert to previous version - `--force`, `--silent`, `--tag`, `--registry` flags - Path traversal protection in tarball extraction - Post-extraction validation of critical files
- Add self-update help to cli-helper-message snap test - Add command-self-update-check test (--check flag and upgrade alias) - Add command-self-update-rollback test (error when no previous version) - Rename help section to "Maintenance Commands" for consistency - Fix description alignment to match other sections
…ap error handling - Add `-msvc` suffix for Windows platform detection (win32-x64-msvc) - Sort cleanup by creation time instead of semver, matching install.sh - Add protected_versions to cleanup to prevent deleting active version on downgrade - Make post-swap operations (shim refresh, cleanup) non-fatal - Add tests for all three fixes - Sync RFC with implementation changes
…dows `Path::is_absolute()` on Windows only recognizes `C:\...` style paths, so `/etc/passwd` from a tar archive was not rejected. Add explicit check for leading `/` since tar archives always use Unix-style paths.
Test the full self-update cycle (check, upgrade alias, update, rollback) on all platforms: Linux x64, macOS x64/ARM64, Linux ARM64 via QEMU, and Windows x64.
`/tmp/...` is not a valid absolute path on Windows, causing `AbsolutePathBuf::new` to return `None`. Use `std::env::temp_dir()` instead.
Add a dedicated job that builds the CLI from source, runs self-update with --tag test --force, verifies version changed, then rollbacks and verifies version restored. Includes version assertions using the installed package.json to ensure correctness after both update and rollback. Runs on all 3 platforms (Linux, macOS, Windows).
CI now installs `vp` to `~/.vite-plus` instead of `~/.vite-plus-dev`, matching the real user environment. Local dev (`vp-dev`) continues to use `~/.vite-plus-dev`. Snap output normalizes both paths to `<vite-plus-home>` for stable cross-environment snapshots.
…y verification Consolidate on `base64-simd` which is already used elsewhere in the codebase, removing the `base64` crate dependency entirely.
Capture stdout/stderr from `vp env setup --refresh` and `vp install --silent` sub-processes instead of inheriting stdio. This prevents ~20 lines of setup instructions and package manager warnings from leaking into the self-update progress output. On failure, captured stderr is included in error messages for diagnostics. Also improve Windows junction error message to include the path and recovery hint.
Replace junction::exists() check with std::fs::remove_dir() fallback chain when removing the `current` junction during self-update. The junction crate may not detect junctions created by cmd /c mklink /J (used by install.ps1), causing OS error 183 on re-creation. Now unconditionally attempts removal via std::fs::remove_dir (safe for junctions/symlinks) with fallback to junction::delete().
Validate the junction swap fix from all three shell types on Windows by adding pwsh and cmd test steps alongside the existing bash test.
fengmk2
force-pushed
the
self-upgrade
branch
4 times, most recently
from
a030d82 to
50406ae
Compare
Both local development and CI now install to ~/.vite-plus using the same `vp` binary, eliminating the separate vp-dev/vp-raw wrapper scripts and ~/.vite-plus-dev directory that caused confusion between dev and release.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cli): add
vp self-updatecommandImplement
vp self-update(alias:vp upgrade) that downloads andinstalls a new vp CLI version from the npm registry with SHA-512
integrity verification.
Features:
--checkflag to check for updates without installing--rollbackto revert to previous version--force,--silent,--tag,--registryflagstest(cli): add snap tests for
vp self-updatecommand