chore: remove dead global logic for update command#1478
Merged
fengmk2 merged 4 commits intovoidzero-dev:mainfrom Apr 26, 2026
Merged
chore: remove dead global logic for update command#1478fengmk2 merged 4 commits intovoidzero-dev:mainfrom
fengmk2 merged 4 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
liangmiQwQ
changed the title
npm install -g calls
fengmk2
approved these changes
Apr 26, 2026
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a part of unreachable code in
update.rs. It is used to runnpm update -gwhen runningvp update -g.It was added in #238, the first implementation of
vp update. But it became dead code after #524 got merged (the PR which introducesvp env).The following code in
cli.rsmakes it unreachable.vite-plus/crates/vite_global_cli/src/cli.rs
Lines 1816 to 1817 in a2876b6
This PR clears the logic about it, including related tests
It was found by Claude Code while I was writing #1477.