Skip to content

pipewire: update to 0.3.65#41846

Closed
cinerea0 wants to merge 2 commits into
void-linux:masterfrom
cinerea0:pipewire
Closed

pipewire: update to 0.3.65#41846
cinerea0 wants to merge 2 commits into
void-linux:masterfrom
cinerea0:pipewire

Conversation

@cinerea0
Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@cinerea0
Copy link
Copy Markdown
Contributor Author

This PR was only able to be submitted without significant patching because the devs released a new version of pipewire-media-session compatible with this version of pipewire. It took them a week to do so, and their release notes indicate that they may not do so again. As such I would like to draw attention to this PR that splits p-m-s out: #38521.

@cinerea0 cinerea0 marked this pull request as draft January 24, 2023 20:14
@cinerea0
Copy link
Copy Markdown
Contributor Author

Temporarily marking as draft as I test other, non-p-m-s patches linked in the release notes.

@cinerea0 cinerea0 marked this pull request as ready for review January 24, 2023 21:04
@ahesford ahesford marked this pull request as draft January 25, 2023 14:53
@ahesford
Copy link
Copy Markdown
Member

For reasons I outlined in #38521 (comment), I think we should decide how we want to handle p-m-s after the 0.3.64 release. Based on that decision, we should use this bump to ensure continuity while also providing an INSTALL.msg to warn users of anything that might break.

@cinerea0
Copy link
Copy Markdown
Contributor Author

cinerea0 commented Jan 25, 2023

I've added an INSTALL.msg file that explains the situation. I worry that it may be too wordy, which would be bad because it seems like no one reads them as it is.

Comment thread srcpkgs/pipewire/INSTALL.msg Outdated
@ahesford ahesford marked this pull request as ready for review January 25, 2023 22:00
@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 26, 2023

Documentation on how to use wireplumber is missing from the handbook, so before telling people they should use it, we should document it.

@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 26, 2023

.65 is released now

@ahesford
Copy link
Copy Markdown
Member

void-linux/void-docs#738

@cinerea0 please pull the wireplumber.desktop file from #41868 into this PR because I plan to mention it in the docs.

@cinerea0
Copy link
Copy Markdown
Contributor Author

cinerea0 commented Jan 27, 2023

I've added wireplumber's desktop file. I have to test if 0.3.65 still allows p-m-s to be built. If it does should I change this PR to use 0.3.65 and we shift removing p-m-s to 0.3.66?

EDIT: 0.3.65 has no problems building p-m-s with our current templates. Still need to do functionality testing.

@ahesford
Copy link
Copy Markdown
Member

If 0.3.65 works with p-m-s, go ahead and bump this. I want to give the INSTALL.msg time to sink in and hopefully get people to transition to wireplumber. We can keep building p-m-s and extend the warning for a few releases if it works without patching.

@cinerea0 cinerea0 changed the title pipewire: update to 0.3.64 pipewire: update to 0.3.65 Jan 27, 2023
@cinerea0
Copy link
Copy Markdown
Contributor Author

p-m-s build correctly locally and CI indicates it builds correctly elsewhere as well.

@ardadem
Copy link
Copy Markdown
Contributor

ardadem commented Jan 28, 2023

@ahesford if you plan to use .desktop file for autostart, i want to point out oreo's comment here since it makes more sense.

@ahesford ahesford closed this in 1756f02 Jan 28, 2023
@ahesford
Copy link
Copy Markdown
Member

There has been a lot of bikeshedding around pipewire, and I suspect there will continue to be more as we iron out the wrinkles in wireplumber documentation. None of that changes the fact that pipewire-media-session will soon become unmaintainable and we should drop it eventually. People should have the maximum possible notice that this will happen, even if the docs aren't quite ready.

@cinerea0 cinerea0 deleted the pipewire branch January 28, 2023 21:01
zen0bit pushed a commit to oSoWoSo/VUR that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants