Skip to content

wicd: clean up INSTALL.msg#34703

Closed
camoz wants to merge 1 commit intovoid-linux:masterfrom
camoz:patch-2
Closed

wicd: clean up INSTALL.msg#34703
camoz wants to merge 1 commit intovoid-linux:masterfrom
camoz:patch-2

Conversation

@camoz
Copy link
Copy Markdown

@camoz camoz commented Dec 26, 2021

No description provided.

@paper42
Copy link
Copy Markdown
Member

paper42 commented Dec 26, 2021

  • the package revision needs to be increased
  • I am not sure how this improves the documentation significantly
  • why did you remove mentioning the network group? Is it not relevant anymore?

@camoz
Copy link
Copy Markdown
Author

camoz commented Dec 26, 2021

the package revision needs to be increased

Oh I didn't know that (I'm quite new to void).
Maybe the changes can be bundled with the next update to wicd?

I am not sure how this improves the documentation significantly

Well the first sentence is semantically wrong ("does not require to have" vs. "requires not to have") so I thought better correct that. I'm not using wicd myself, just saw it on the go.

why did you remove mentioning the network group? Is it not relevant anymore?

Per void docs the network group isn't used anymore: https://docs.voidlinux.org/config/users-and-groups.html#default-groups

@Duncaen
Copy link
Copy Markdown
Member

Duncaen commented Dec 26, 2021

I would vote to just remove INSTALL.msg, we don't have them for the other packages that have the same requirement like NetworkManager and its sufficiently documented in the handbook.

Per void docs the network group isn't used anymore: https://docs.voidlinux.org/config/users-and-groups.html#default-groups

The documentation here is wrong, there are packages that use this group, like wicd and networkmanager.

@camoz
Copy link
Copy Markdown
Author

camoz commented Dec 26, 2021

Personally, I don't care if this gets merged or INSTALL.msg is removed. Removing seems simpler and sounds reasonable to me.

paper42 added a commit to paper42/void-packages that referenced this pull request Feb 27, 2022
* remove -gtk subpackage, it still uses python2 libraries

Closes void-linux#34703
@ahesford
Copy link
Copy Markdown
Member

#36116

@ahesford ahesford closed this Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants