Material string property analyzer methods#9
Merged
Conversation
vad710
reviewed
Oct 16, 2017
|
|
||
| var containingClass = methodSymbol.ContainingType; | ||
|
|
||
| // check if the method is the one from UnityEngine.Animator |
Owner
There was a problem hiding this comment.
Looks like a copy+paste issue on the name
vad710
approved these changes
Oct 16, 2017
Owner
vad710
left a comment
vad710
left a comment
There was a problem hiding this comment.
One small copy+paste issue on a comment, but gonna merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Material class has many methods that take either string or int parameter name.
Int parameter should be used for performance.
Use https://docs.unity3d.com/ScriptReference/Shader.PropertyToID.html to convert string to int.