Fix NullPointerException in ContainerLessJdbcDelegate when using ScriptUtils#11630
Open
himi-sh wants to merge 2 commits intotestcontainers:mainfrom
Open
Fix NullPointerException in ContainerLessJdbcDelegate when using ScriptUtils#11630himi-sh wants to merge 2 commits intotestcontainers:mainfrom
himi-sh wants to merge 2 commits intotestcontainers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves a NullPointerException (NPE) that occurred when running SQL scripts via
ScriptUtilson aContainerLessJdbcDelegate.Root Cause
The issue stemmed from field shadowing in the delegate classes:
JdbcDatabaseDelegatedefines a privateConnection connectionfield.ContainerLessJdbcDelegate(subclass) also declared its own privateConnection connectionfield.JdbcDatabaseDelegateto remain uninitialized.ScriptUtilsfinished, it calledcloseConnectionQuietly(Statement)in the parent class, attempting to close its null connection, triggering the NPE.Solution
Subclass Close Implementation
closeConnectionQuietly(Statement statement)inContainerLessJdbcDelegateto ensure the subclass connection is closed properly.Null-Safety Enhancements
JdbcDatabaseDelegate#closeConnectionQuietlyto prevent crashes if the connection is partially initialized.Code Style Compliance
Related Issues
Verification
ContainerLessJdbcDelegateTest.javaStatementandConnectionare closed without throwing NPE.