Resolve android pubky parity issues from #902 by ben-kaufman · Pull Request #905 · synonymdev/bitkit-android

ben-kaufman · 2026-04-23T12:53:28Z

resolves #902

Description

restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
align Android profile and contacts flows with the iOS parity work where applicable
improve pubky routing from clipboard and scanner input
polish profile/contact edit flows, delete flows, and related copy
add unit coverage for pubky restore, delete recovery, and contact import routing

Preview

N/A

QA Notes

./gradlew compileDevDebugKotlin
./gradlew testDevDebugUnitTest
./gradlew detekt
installed and launched to.bitkit.dev on connected device 2409BRN2CA

Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>

ben-kaufman · 2026-04-24T16:16:37Z

@jvsena42 everything should be resolved now, please recheck

piotr-iohk · 2026-04-25T15:12:32Z

There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)

duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)

Screen.Recording.2026-04-25.at.17.06.22.mov

retry button does nothing on adding contact on qr code scan

Screen.Recording.2026-04-25.at.17.05.12.mov

jvsena42

Add contact from Contacts screen is not validating if a contact was already added

Screen_recording_20260427_082659.webm

claude · 2026-04-27T15:04:04Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

piotr-iohk

LGTM, to merge this.

Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)

jvsena42

Still see a divergence when trying to add an existent contact from home and from contacts

Screen_recording_20260428_070658.webm

piotr-iohk · 2026-04-28T10:25:08Z

Still see a divergence when trying to add an existent contact from home and from contacts

@jvsena42 @ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍

jvsena42 · 2026-04-28T10:27:23Z

Still see a divergence when trying to add an existent contact from home and from contacts

@jvsena42 @ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍

Agreed, this one has 31 modified files already. I'll keep testing

jvsena42

Tested:

Login with pubky-ring
Add contact from home scanner
Try to add self key -> blocked
Reset -> restore -> profile restored
Add contact from home
Add contact from contact screen

Some points to fix in the next PR: #909

ben-kaufman added 2 commits April 23, 2026 07:52

fix: polish pubky profile flows

bd77518

docs: add pr number to changelog

77818be

ben-kaufman marked this pull request as ready for review April 23, 2026 12:58

ben-kaufman changed the title ~~[codex] resolve android pubky parity issues from #902~~ Resolve android pubky parity issues from #902 Apr 23, 2026

ben-kaufman requested a review from piotr-iohk April 23, 2026 12:58

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated

fix: avoid pubky backup throw

5514d9c

piotr-iohk reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/res/values/strings.xml Outdated

Comment thread app/src/main/res/values/strings.xml Outdated

Comment thread app/src/main/res/values/strings.xml Outdated

piotr-iohk mentioned this pull request Apr 23, 2026

Feat/pubky profile e2e tests synonymdev/bitkit-e2e-tests#147

Open

This comment was marked as resolved.

Sign in to view

ben-kaufman and others added 4 commits April 23, 2026 10:06

Update app/src/main/res/values/strings.xml

48b29f6

Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>

Update app/src/main/res/values/strings.xml

efdbf06

Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>

Update app/src/main/res/values/strings.xml

2e2706b

Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>

fix: truncate pubky contact names

a787832

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/Tag.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/test/java/to/bitkit/ui/WalletViewModelTest.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt Outdated

fix: address claude review nits

93e981c

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

fix: update changelog category

d325bc3

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt Outdated

fix: address claude pr feedback

3dbc299

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated

fix: clean up modifier call sites

9bdfc4f

claude Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

fix: harden pubky restore

4033b1e

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated

claude Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated

fix: address claude review

ebd1fe1

This comment has been minimized.

Sign in to view

piotr-iohk mentioned this pull request Apr 25, 2026

Resolve iOS pubky parity issues from #902 synonymdev/bitkit-ios#527

Merged

jvsena42 requested changes Apr 27, 2026

View reviewed changes

Merge branch 'master' into codex-pubky-902-android

ee5b348

ben-kaufman requested review from jvsena42 and piotr-iohk April 27, 2026 14:54

piotr-iohk approved these changes Apr 28, 2026

View reviewed changes

jvsena42 requested changes Apr 28, 2026

View reviewed changes

jvsena42 approved these changes Apr 28, 2026

View reviewed changes

ben-kaufman merged commit 93b36b5 into master Apr 28, 2026
20 checks passed

ben-kaufman deleted the codex-pubky-902-android branch April 28, 2026 12:39

Conversation

ben-kaufman commented Apr 23, 2026

Description

Preview

QA Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

ben-kaufman commented Apr 24, 2026

Uh oh!

piotr-iohk commented Apr 25, 2026

Uh oh!

jvsena42 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Apr 27, 2026

Code review

Uh oh!

piotr-iohk left a comment

Choose a reason for hiding this comment

Uh oh!

jvsena42 left a comment

Choose a reason for hiding this comment

Uh oh!

piotr-iohk commented Apr 28, 2026

Uh oh!

jvsena42 commented Apr 28, 2026

Uh oh!

jvsena42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jvsena42 left a comment •

edited

Loading