Skip to content

Remove move from conn->request_#2292

Merged
stephenberry merged 1 commit intomainfrom
remove-request-move
Feb 1, 2026
Merged

Remove move from conn->request_#2292
stephenberry merged 1 commit intomainfrom
remove-request-move

Conversation

@stephenberry
Copy link
Copy Markdown
Owner

No description provided.

@stephenberry
Copy link
Copy Markdown
Owner Author

@clagix, I'm removing the std::move, as you're right that this is safer and not a performance bottleneck.

@wilkolbrzym-coder
Copy link
Copy Markdown

It seems send_error_response is gone (which is good), but the raw send_response(std::shared_ptr<socket_type> socket, ...) method is still present at the bottom of the http_server struct. Since it appears unused, it can be removed too.

@stephenberry stephenberry merged commit 001ef7c into main Feb 1, 2026
43 checks passed
@stephenberry stephenberry deleted the remove-request-move branch February 1, 2026 20:42
@clagix
Copy link
Copy Markdown
Contributor

clagix commented Feb 1, 2026

It seems send_error_response is gone (which is good), but the raw send_response(std::shared_ptr<socket_type> socket, ...) method is still present at the bottom of the http_server struct. Since it appears unused, it can be removed too.

@wilkolbrzym-coder I don't see this method anymore. I think it has somehow resolved itself.

@wilkolbrzym-coder
Copy link
Copy Markdown

It seems send_error_response is gone (which is good), but the raw send_response(std::shared_ptr<socket_type> socket, ...) method is still present at the bottom of the http_server struct. Since it appears unused, it can be removed too.

@wilkolbrzym-coder I don't see this method anymore. I think it has somehow resolved itself.

@clagix yes the problem has already been solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants