Skip to content

fix: move db credentials into a secret#557

Merged
adwk67 merged 6 commits intomainfrom
fix/use-secret-for-db-credentials
May 22, 2024
Merged

fix: move db credentials into a secret#557
adwk67 merged 6 commits intomainfrom
fix/use-secret-for-db-credentials

Conversation

@adwk67
Copy link
Copy Markdown
Member

@adwk67 adwk67 commented May 7, 2024

Description

fixes #352

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved (implicitly as the same as https://github.com/stackabletech/hive-operator/pull/452)
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@adwk67 adwk67 marked this pull request as ready for review May 7, 2024 10:10
@maltesander maltesander self-requested a review May 10, 2024 06:57
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking and a question, LGTM otherwise!

Comment thread CHANGELOG.md Outdated
Comment thread rust/crd/src/lib.rs
@maltesander maltesander added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels May 10, 2024
@adwk67
Copy link
Copy Markdown
Member Author

adwk67 commented May 21, 2024

Local tests:

--- PASS: kuttl (4735.62s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_druid-latest-28.0.1_zookeeper-latest-3.9.2_s3-use-tls-true_openshift-false (475.44s)
        --- PASS: kuttl/harness/cluster-operation_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-latest-3.3.6_openshift-false (643.17s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-internal-and-server-tls_openshift-false (354.22s)
        --- PASS: kuttl/harness/ldap-authentication_druid-28.0.1_zookeeper-latest-3.9.2_opa-0.61.0_hadoop-latest-3.3.6_ldap-use-tls-true_ldap-no-bind-credentials-false_openshift-false (261.79s)
        --- PASS: kuttl/harness/authorizer_druid-28.0.1_zookeeper-latest-3.9.2_opa-0.61.0_hadoop-3.3.6_openshift-false (287.51s)
        --- PASS: kuttl/harness/ingestion-s3-ext_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (335.59s)
        --- PASS: kuttl/harness/logging_druid-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (319.82s)
        --- PASS: kuttl/harness/s3-deep-storage_druid-latest-28.0.1_zookeeper-latest-3.9.2_s3-use-tls-true_openshift-false (240.04s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-no-tls_openshift-false (227.01s)
        --- PASS: kuttl/harness/orphaned-resources_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (338.17s)
        --- PASS: kuttl/harness/tls_druid-latest-28.0.1_zookeeper-latest-3.9.2_tls-mode-internal-and-server-tls-and-tls-client-auth_openshift-false (302.12s)
        --- PASS: kuttl/harness/ingestion-no-s3-ext_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (248.79s)
        --- PASS: kuttl/harness/smoke_druid-28.0.1_zookeeper-3.8.3_hadoop-3.3.6_openshift-false (284.56s)
        --- PASS: kuttl/harness/resources_druid-latest-28.0.1_zookeeper-latest-3.9.2_openshift-false (110.81s)
        --- PASS: kuttl/harness/hdfs-deep-storage_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-3.3.6_openshift-false (305.93s)

@adwk67
Copy link
Copy Markdown
Member Author

adwk67 commented May 21, 2024

@adwk67 adwk67 requested a review from maltesander May 21, 2024 12:59
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 2e6dcf0 May 22, 2024
@adwk67 adwk67 deleted the fix/use-secret-for-db-credentials branch May 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Database config to a secret

2 participants