adopt to compare string terminology.#315
Open
sassembla wants to merge 1 commit intosta:masterfrom
Open
Conversation
some server returns handshake headers with case-insensitive rule. according to HTTP1.1(https://tools.ietf.org/html/rfc2616#section-2.1), , "literal" Quotation marks surround literal text. Unless stated otherwise, the text is case-insensitive. also in RFC of WS(https://tools.ietf.org/html/rfc6455#section-4.1), Comparing two strings in an _ASCII case-insensitive_ manner means comparing them exactly, code point for code point, except that the characters in the range U+0041 to U+005A (i.e., LATIN CAPITAL LETTER A to LATIN CAPITAL LETTER Z) and the corresponding characters in the range U+0061 to U+007A (i.e., LATIN SMALL LETTER A to LATIN SMALL LETTER Z) are considered to also match.
|
Is the compiler always cognizant of the fact that Perhaps a better way to implement the change you describe would be to use the mechanisms already built in to the
Did you run into a problem with the comparison being case-sensitive? From a brief look at the code, it seems to me it would be case-insensitive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some server returns handshake headers with case-insensitive rule.
according to HTTP1.1(https://tools.ietf.org/html/rfc2616#section-2.1),
,
"literal"
Quotation marks surround literal text. Unless stated otherwise,
the text is case-insensitive.
also in RFC of WS(https://tools.ietf.org/html/rfc6455#section-4.1),
Comparing two strings in an ASCII case-insensitive manner means
comparing them exactly, code point for code point, except that the
characters in the range U+0041 to U+005A (i.e., LATIN CAPITAL LETTER
A to LATIN CAPITAL LETTER Z) and the corresponding characters in the
range U+0061 to U+007A (i.e., LATIN SMALL LETTER A to LATIN SMALL
LETTER Z) are considered to also match.