[FME-4363] Use properties param instead of options#208
Merged
ZamoraEmmanuel merged 3 commits intodevelopmentfrom Jul 22, 2025
Merged
[FME-4363] Use properties param instead of options#208ZamoraEmmanuel merged 3 commits intodevelopmentfrom
ZamoraEmmanuel merged 3 commits intodevelopmentfrom
Conversation
EmilianoSanchez
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split Evaluator
What did you accomplish?
Use properties param instead of options for impressions properties feature
Modified functionality to log a warning and ignore properties if are invalid and send the impression anyways.
Added maximum of 15 keys for properties sent as query params in GET requests (no limits for POST requests)
Update /manager/split and /manager/splits responses in api-docs to add impressionsDisabled and prerequisites properties
Update get treatment/s related definitions in open-api to add options parameter
Added impressions disabled property to split and splits tests
Added tests coverage
Updated api-docs page