Enhance pickle compatibility: support legacy tuple state and maintain…

[polybassa]

… packet metadata during serialization

The new regression tests protect against breaking older pickle payloads by ensuring legacy tuple-state unpickling still works. They also lock in current behavior for the new state format by checking full metadata and comments fidelity after pickle roundtrip. This gives coverage for both backward compatibility and current serialization behavior in one place: test/regression.uts.

Checklist :

• If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
• I squashed commits belonging together
• I added unit tests or explained why they are not relevant
• I executed the regression tests (using tox)
• If the PR is still not finished, please create a Draft Pull Request
• This PR uses (partially) AI-generated code. If so:
  • I ensured the generated code follows the internal concepts of scapy
  • This PR has a test coverage > 90%
  • I reviewed every generated line
  • If this PR contains more than 500 lines of code (excluding unit tests) I considered splitting this PR.
  • I considered interoperability tests with existing packages or utilities to ensure conformity of a newly generated protocol

I understand that failing to mention the use of AI may result in a ban. (We do not forbid it, but you must play fair. Be warned !)

fixes #xxx

[codecov]

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.26%. Comparing base (1745d39) to head (2bece55).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
scapy/packet.py	88.57%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4982      +/-   ##
==========================================
- Coverage   80.27%   80.26%   -0.01%     
==========================================
  Files         382      382              
  Lines       94349    94362      +13     
==========================================
+ Hits        75736    75739       +3     
- Misses      18613    18623      +10     

Files with missing lines	Coverage Δ
scapy/packet.py	84.70% <88.57%> (-0.14%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[polybassa]

@guedou I've encountered a problem that "old" pickled values can not be unpickled anymore. I've added support for the legacy pickle structure.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[guedou]

Looks good to me, but I don't understand why we need to have backwards compatibility for this feature.

[polybassa]

I stumbled over it when un-pickling older objects. I would help me for some use cases, if we stay backward compatible.

[guedou]

I really don’t feel that we should keep both serialization methods.Sent from my iPhoneOn 27 Apr 2026, at 19:29, Nils Weiss ***@***.***> wrote:polybassa left a comment (secdev/scapy#4982) I stumbled over it when un-pickling older objects. I would help me for some use cases, if we stay backward compatible. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>