Add <NavigationProvider/> to <SeamProvider/>#138
Closed
mikewuu wants to merge 1 commit into
Closed
Conversation
Merged
azat-co
approved these changes
May 12, 2023
Contributor
azat-co
left a comment
azat-co
left a comment
There was a problem hiding this comment.
LGTM
just to confirm the onBack is optional, right?
Contributor
Author
Yep! I think the idea is to allow users to override it if they want. |
Member
|
Closing in favor of #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<NavigationProvider/>onBackoverride at component levelAlthough this approach offers a better API, it doesn't work well when inside a modal because having
<NavigationProvider/>at the top-level (included) will re-render all children (including the modal)CleanShot.2023-05-12.at.23.16.26.mp4