-
-
Notifications
You must be signed in to change notification settings - Fork 231
Rails alternative environment and additional key lookup during env mapping #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
neilwilliams
wants to merge
7
commits into
rubyconfig:master
from
neilwilliams:feature/rails-alternative-environment
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1483002
Created the new config for using a different envfironment, instead of…
neilwilliamsdvla da5dcd0
Merge branch 'master' into feature/rails-alternative-environment
neilwilliamsdvla 57a3dfa
Created lookup method which allows an ENV to be passed to overide som…
neilwilliamsdvla 28f9868
Locked down byebug and ignored byebug related files
neilwilliamsdvla 9b10fed
Removing byebug
neilwilliamsdvla 17321b9
Removing more byebug artifacts
neilwilliamsdvla 3908f6c
Fixing typo in template and removing pointless file changes
neilwilliamsdvla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,9 +37,15 @@ Donate: \e[34mhttps://opencollective.com/rubyconfig/donate\e[0m\n" | |
|
|
||
| # Default RSpec run will test against latest Rails app | ||
| unless ENV['APPRAISAL_INITIALIZED'] || ENV['GITHUB_ACTIONS'] | ||
| gems_to_install = /gem "(.*?)", "(.*?)"(?!, platform: (?!\[:ruby\]))/ | ||
| File.read(Dir['gemfiles/rails*.gemfile'].sort.last).scan(gems_to_install) do |name, version| | ||
| s.add_development_dependency name, version | ||
| gems_to_install = /gem "(.*?)", "(.*?)"(, platform: \:(.*))?/ | ||
| File.read(Dir['gemfiles/rails*.gemfile'].sort.last).scan(gems_to_install) do |name, version, _, platform| | ||
| if platform.nil? | ||
| s.add_development_dependency name, version | ||
| else | ||
| if platform.to_s == RUBY_ENGINE | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor, but prefer |
||
| s.add_development_dependency name, version | ||
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module Config | ||
| VERSION = '2.2.1'.freeze | ||
| VERSION = '2.3.0'.freeze | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,7 +218,7 @@ | |
| expect(config.array[1].b).to eq("two") | ||
| end | ||
| end | ||
|
|
||
| end | ||
|
|
||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do this to avoid capturing that third unused value