Open
Conversation
pvdb
force-pushed
the
simplify_standard_system_dir
branch
from
825e366 to
496e60d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hot on the heels of #669, this small refactor dedupes the multiple method definitions by inlining the
Win32.windows?check, which means we don't end up with two different method implementations for the same thing, which is a tad confusing for e.g.ctags:It also replaces the duplicated
Win32.windows?check with the existingRake::Application.windows?utility function, already used elsewhere in the class.This in turn allowed me to add two explicit tests, one for the Windows behaviour, another one for the Unix behaviour; it does this by stubbing the
Rake::Application.windows?utility function, which is indeed a tad strange, but both tests are modelled after the existingtest_load_from_calculated_system_rakefile(which is arguably even stranger, as it needs to stub a private function in order to do its thing) 😃