x509store: check for error of X509_STORE_set_ex_data()#1032
Merged
rhenium merged 1 commit intoruby:masterfrom Apr 20, 2026
Merged
x509store: check for error of X509_STORE_set_ex_data()#1032rhenium merged 1 commit intoruby:masterfrom
rhenium merged 1 commit intoruby:masterfrom
Conversation
Member
|
Thanks for catching this. Other occurrences of |
Contributor
Author
|
Do you want me to do that in this PR or would you want to merge this first? |
This can technically fail because it internally performs allocations. Also confirmed by the man page [1]. [1] (among other functions on this page) https://docs.openssl.org/3.5/man3/BIO_get_ex_new_index
Member
|
It's straightforward change so I just updated this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can technically fail because it internally performs allocations. Also confirmed by the man page [1].
[1] (among other functions on this page) https://docs.openssl.org/3.5/man3/BIO_get_ex_new_index
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.