Make ament_cmake a buildtool dependency#2689
Merged
Merged
Conversation
The `ament_cmake` package isn't needed at runtime and so should only be listed as a `buildtool_dependency`, as is done in most other packages. Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai>
ahcorde
approved these changes
Nov 29, 2024
clalancette
requested changes
Dec 1, 2024
Since there's already a buildtool dependency on ament_cmake_ros, having ament_cmake as well is redundant. Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai>
clalancette
approved these changes
Dec 1, 2024
Contributor
|
Pulls: #2689
|
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
* Make ament_cmake a buildtool dependency The `ament_cmake` package isn't needed at runtime and so should only be listed as a `buildtool_dependency`, as is done in most other packages. * Remove the ament_cmake dependency entirely Since there's already a buildtool dependency on ament_cmake_ros, having ament_cmake as well is redundant. Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
HarunTeper
pushed a commit
to HarunTeper/rclcpp
that referenced
this pull request
Dec 9, 2024
* Make ament_cmake a buildtool dependency The `ament_cmake` package isn't needed at runtime and so should only be listed as a `buildtool_dependency`, as is done in most other packages. * Remove the ament_cmake dependency entirely Since there's already a buildtool dependency on ament_cmake_ros, having ament_cmake as well is redundant. Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai> Signed-off-by: HarunTeper <harun.teper@tu-dortmund.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rclcpp_actionpackage currently listsament_cmakeas a generic<depend>dependency, which implies that it's needed at both build-time and run-time. However,ament_cmakeisn't used at runtime and so should only be listed as abuildtooldependency, as is done in most other packages.