Migrating to SIP5 layouts#1
Merged
Merged
Conversation
this is not the default, but some ROS-specific bindings break without it in header-inline throw statements (e.g. in Poco/Mutex_POSIX.h)
e.g. `.cpython-310-x86_64-linux-gnu.so` instead of just '.so'
This is somewhat hacky, but at least passes all libraries to the linker. The previous version of this block was plain broken in the sip5 transition.
Isolation is not needed as we expect to build in the system environment. Additionally the isolation wrappers can break sip-specific build commands by hiding the path of `sip-distinfo`.
sip4 does not adhere to PEP-3149 https://peps.python.org/pep-3149/ by default, so we force it to do so in the name of consistency with the sip5 generator.
rhaschke
approved these changes
Oct 17, 2024
Member
Author
|
I don't think it makes sense to keep this lying around in a PR any longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was initial work by @seanyen in this pull-request, but it was still quite incomplete.
I added some fixes that make it work with linux systems.
Minor changes are required in all downstream packages, as the cpython file extension changed to include not only
.so, but a whole version string, such as.cpython-310-x86_64-linux-gnu.so.sip_helper.cmake now provides a handy variable
PYTHON_EXTENSION_MODULE_SUFFIXfor this value.Also sip file syntax removed at least one previously deprecated statement (no version number after module declaration), but that should already be addressed in noetic branches.