Conversation
Member
|
@aaltat .. this is a very silly questions but making sure my thinking is correct .. anyone installing seleniumlibrary who has not pinned pythonlibcore has been installing 3.0.0 since Jun 11, 2021, correct? |
Member
|
Ran against the latest set of tests and main branch code here with passing results. |
Contributor
Author
|
Should be correct at least with new installations people should get the latest PLC. |
Member
|
For me it was a question of seeing the scope of affected code/functionality by this change and knowing how to test. It was tough for me to understand directly how this might affect the library. Having it out in the field for some time, to me, helps to shift testing from "knowing the code" to "experiencing the code". Kiitos for the contribution! Merging into master .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1733