Fixed memory leak that happened when calling apply#3
Open
PieroV wants to merge 1 commit intorjw57:masterfrom
Open
Fixed memory leak that happened when calling apply#3PieroV wants to merge 1 commit intorjw57:masterfrom
PieroV wants to merge 1 commit intorjw57:masterfrom
Conversation
Registration.apply caused a memory leak because Frame.create did not associate freenect2_frame_dispose to the garbage collector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registration.apply caused a memory leak because Frame.create did not associate freenect2_frame_dispose to the garbage collector.
A simple line fixes the problem. I tested this on another machine, but I do not have the Kinect here, so I cannot test the file right now, but should work.