You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This changeset improves error messages for failed TCP/IP connections when ext-sockets is not available on Linux. This means it will now consistently report errno/errstr on most supported platforms such as this:
$ telnet 192.168.0.1 8080
Trying 192.168.0.1...
telnet: Unable to connect to remote host: Network is unreachable
$ php examples/11-http-client.php 192.168.0.1
RuntimeException: Connection to tcp://192.168.0.1:80 failed: Network is unreachable in …/TcpConnector.php:115
I've updated this to use the above work-around only when applicable. This is only known to work on Linux and known to not work on Mac and Windows. Using ext-sockets to access the SO_ERROR remains the preferred way, so most other platforms should be supported as well.
For future reference: This work-around uses "error slippage" which has been known to work for decades, see e.g. https://cr.yp.to/docs/connect.html. The recommended way would be to use a read(fd, 0) call, but PHP's fread($stream, 0) rejects empty reads and a fread($stream, 1) will return false without exposing the errno/errstr. Using fwrite($stream, $data) is known to work on Linux, but we might be able to find other platforms that could potentially also take advantage of this. Given that this is only used when ext-sockets is not available and this changeset already provides value on its own, I would suggest leaving this up for a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves error messages for failed TCP/IP connections when
ext-socketsis not available on Linux. This means it will now consistently report errno/errstr on most supported platforms such as this:$ telnet 192.168.0.1 8080 Trying 192.168.0.1... telnet: Unable to connect to remote host: Network is unreachable $ php examples/11-http-client.php 192.168.0.1 RuntimeException: Connection to tcp://192.168.0.1:80 failed: Network is unreachable in …/TcpConnector.php:115Builds on top of #265, #171, reactphp/dns#171, reactphp/dns#172 and others