Skip to content

[3.x] Update test environment for PHP 7.2 to compatible PHPUnit version#284

Merged
clue merged 1 commit intoreactphp:3.xfrom
WyriHaximus-labs:3.x-update-test-environment-for-PHP-7.2
May 10, 2026
Merged

[3.x] Update test environment for PHP 7.2 to compatible PHPUnit version#284
clue merged 1 commit intoreactphp:3.xfrom
WyriHaximus-labs:3.x-update-test-environment-for-PHP-7.2

Conversation

@WyriHaximus
Copy link
Copy Markdown
Member

Since composer 2.9 it blocks installing package versions with known CVE's. This only affects PHP version 7.2 and up, 7.1 and lower use composer 2.2.27 (at the time of writing). So any open CVE's aren't an issue when running composer install. The reason this became an issue now is that with CVE-2026-24765 affecting all PHPUnit versions before versions 8.5.52, 9.6.33, 10.5.62, 11.5.50, and 12.5.8. There is no PHPUnit version in the ^7.5 range that isn't effected, this we're adding ^8.5 to the version range and thus we get the only not impacted version in te ^8.5 range 8.5.52.

Since [composer `2.9`](https://github.com/composer/composer/releases/tag/2.9.0) it blocks installing package versions with [known CVE's](composer/composer#11956). This only affects PHP version 7.2 and up, 7.1 and lower use composer `2.2.27` (at the time of writing). So any open CVE's aren't an issue when running composer install.
The reason this became an issue now is that with [`CVE-2026-24765`](GHSA-vvj3-c3rp-c85p) affecting all PHPUnit versions before versions `8.5.52`, `9.6.33`, `10.5.62`, `11.5.50`, and `12.5.8`. There is no PHPUnit version in the `^7.5` range that isn't effected, this we're adding `^8.5` to the version range and thus we get the only not impacted version in te `^8.5` range `8.5.52`.
Copy link
Copy Markdown
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for looking into this, changes LGTM 👍

Looks like we both arrived at the exact same changes (clue/reactphp-redis#180), thanks for applying this consistently for all components.

@clue clue merged commit 0b45df3 into reactphp:3.x May 10, 2026
30 checks passed
clue pushed a commit to reactphp/socket that referenced this pull request May 10, 2026
This changes ensures we can continue run PHPUnit on PHP 7.2 by updating PHPUnit to 8.5. This is due to recent improvements in composer as discussed in reactphp/event-loop#284.
@clue clue deleted the 3.x-update-test-environment-for-PHP-7.2 branch May 10, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants