You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issues is that findDOMNode is only called a single time after componentDidUpdate and the return value is used for every transition callback that is triggered by this update. If the child however changes its DOM node while transitioning this value is stale.
Edit: This is now a breaking change from 4.4.0 because #559 changes the signatures of on* callbacks when nodeRef is used. I think this behavior is unnecessary and makes it harder to reason about the component.
The issues is that findDOMNode is only called a single time after componentDidUpdate and the return value is used for every transition callback that is triggered by this update. If the child however changes its DOM node while transitioning this value is stale.
I'm looking into code and it seems after #559 statement above is false one?!
Or I don't understand exactly what you mean.
Also current implementation in this PR, it seems just to add back node in callback functions. this.getNode does not add too much value 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues is that
findDOMNodeis only called a single time aftercomponentDidUpdateand the return value is used for every transition callback that is triggered by this update. If the child however changes its DOM node while transitioning this value is stale.Edit: This is now a breaking change from 4.4.0 because #559 changes the signatures of
on*callbacks whennodeRefis used. I think this behavior is unnecessary and makes it harder to reason about the component.