breaking: update Node minimum version to 18#1986
Merged
thymikee merged 3 commits intoreact-native-community:mainfrom Jul 17, 2023
Merged
breaking: update Node minimum version to 18#1986thymikee merged 3 commits intoreact-native-community:mainfrom
thymikee merged 3 commits intoreact-native-community:mainfrom
Conversation
szymonrybczak
requested changes
Jul 4, 2023
Collaborator
There was a problem hiding this comment.
Thanks! You need also to change node version in the engines in package.json, see here:
Lines 20 to 22 in 5d8a847
also
@types/node in few packages, in babel.config.js and in .github/workflows/test.yml just leave Node 18 for running unit tests.
Member
|
@Shubham1429 can you rebase and address the feedback? :) |
85ad40b to
7220640
Compare
cortinico
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Set minimum Node version to 18.
Part of #1936
Reference: facebook/react-native#37709