Support versioning of ramda-repl js file#190
Conversation
|
Thanks for the research on the rawgit versioning, I'm happy with the idea of adding the version number. I don't really like reverting back to Handlebars, because then we lose the inheritance for common content of the site. I'm also not a fan of including an unused dependency just to get the version number. |
I did give the pug approach a try. But there's some styling issue with the width of the repl. In addition, it looks like the current production site is still using the old html and styles. I thought it's safer to just update based on the older version and wait for someone more familiar with the pug approach to proper test it and release it.
In this sense, we are also including In short, do you prefer me to directly update the |
86d5a5a to
b21ae06
Compare
|
I've updated the PR to just use the I updated both The styling issue with PUG repl is addressed in a separate PR: #191 Let me know whether this works for you @MattMS |
|
ping reviewers |
|
Thanks @zehua, this all looks fine to me. I'll check out your other PRs next. |
|
REPL with that version was not deployed. |

We started to use
rawgitsince #136. From the comment in ramda/repl#50 (comment), rawgit faq does not recommend usingmasteras the tag as they do not clear cache.This PR attempts to use tag from
ramda-replinstead of always usingmasterto overcome this issue.I also added a util script to generate the repl/index.html from handlerbars. Sorry that I could not figure out how to use the new pug based template introduced in #175. It also looks like the current repl/index.html has been manually modified in the past few commits. Feel free to update the pug template to support the same, if this PR is accepted. @MattMS
TODO:
@craigdallimore @buzzdecafe