[maskedtensor] Adagrad sparse semantics [3/4]#2052
Merged
Conversation
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
janeyx99
reviewed
Sep 26, 2022
janeyx99
reviewed
Sep 26, 2022
janeyx99
reviewed
Sep 26, 2022
janeyx99
reviewed
Sep 26, 2022
janeyx99
reviewed
Sep 26, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
janeyx99
reviewed
Sep 27, 2022
Contributor
|
Generally, I got the point of the tutorial eventually, so nice! I do believe there are some opportunities to make the tutorial clearer, including:
|
Co-authored-by: Nikita Shulga <nshulga@fb.com>
f5b048f to
e7fbf51
Compare
added 3 commits
October 20, 2022 11:19
e7fbf51 to
d3b11e7
Compare
Contributor
Author
|
I like the comment on switching the conclusion to the front a lot -- I've implemented that :) |
f141231 to
d276617
Compare
janeyx99
reviewed
Oct 21, 2022
janeyx99
reviewed
Oct 21, 2022
janeyx99
reviewed
Oct 21, 2022
janeyx99
reviewed
Oct 21, 2022
janeyx99
reviewed
Oct 21, 2022
janeyx99
approved these changes
Oct 21, 2022
Contributor
janeyx99
left a comment
There was a problem hiding this comment.
Overall good! Just a few more minor clarifications; the general sense is conveyed.
I haven't verified that the links all work (the preview's not done yet), but spot checking a few seem good.
e579146 to
25e33cf
Compare
25e33cf to
304f08d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructured the PR stack from #2042
The new format will be:
PR #1: Overview Tutorial
PR #2: Sparsity
PR #3: Adagrad sparse semantics, i.e. what does MaskedTensor make easier -- this one
PR #4: Advanced semantics, e.g. NumPy differences and reduction semantics from Old overview