Rename build files from TARGETS to BUCK (group ID: -3982651347005005195)#19427
Rename build files from TARGETS to BUCK (group ID: -3982651347005005195)#19427bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104414874
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414874. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19427
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 Pending, 1 Unclassified FailureAs of commit 0e2e4f0 with merge base 9889c7c ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR migrates a few extension build definitions from TARGETS files into BUCK files, aligning with the repository’s build-file naming/migration approach and enabling conditional fbcode vs non-fbcode target definitions via migration macros.
Changes:
- Removed
TARGETSfiles underextension/tensorandextension/runner_util(andextension/runner_util/test). - Updated corresponding
BUCKfiles to usefbcode_target/non_fbcode_targetwrappers around existingdefine_common_targetsentrypoints. - Updated
extension/pytree/test/BUCKto wrap test rules withfbcode_target.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/tensor/TARGETS | Removed legacy TARGETS file now merged into BUCK. |
| extension/tensor/BUCK | Adds migration macro wrappers for fbcode/non-fbcode target definition. |
| extension/runner_util/TARGETS | Removed legacy TARGETS file now merged into BUCK. |
| extension/runner_util/BUCK | Adds migration macro wrappers for fbcode/non-fbcode target definition. |
| extension/runner_util/test/TARGETS | Removed legacy TARGETS file now merged into BUCK. |
| extension/runner_util/test/BUCK | Adds migration macro wrappers; fbcode path passes is_fbcode=True. |
| extension/pytree/test/BUCK | Wraps unittest targets in fbcode_target for migration compatibility. |
Comments suppressed due to low confidence (1)
extension/pytree/test/BUCK:1
non_fbcode_targetis loaded but never used in this file. Dropping the unused symbol from thebuild_file_migration.bzlload would reduce noise and avoid confusion about whether a non-fbcode version of these tests is expected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain fbcode-only targets. | ||
|
|
||
| load(":targets.bzl", "define_common_targets") | ||
|
|
||
|
|
| # !!!! fbcode/executorch/extension/runner_util/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! | ||
|
|
||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. |
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. | ||
|
|
||
| load(":targets.bzl", "define_common_targets") | ||
|
|
||
| oncall("executorch") | ||
|
|
||
| define_common_targets() | ||
| fbcode_target(_kind = define_common_targets,) |
| # !!!! fbcode/executorch/extension/runner_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! | ||
|
|
||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. |
Reviewed By: bigfootjon
Differential Revision: D104414874