Skip to content

Rename build files from TARGETS to BUCK (group ID: 7455922743067832490) (#19426)#19426

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414871
Open

Rename build files from TARGETS to BUCK (group ID: 7455922743067832490) (#19426)#19426
bigfootjon wants to merge 1 commit intomainfrom
export-D104414871

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19426

Reviewed By: bigfootjon

Differential Revision: D104414871

Copilot AI review requested due to automatic review settings May 8, 2026 23:21
@bigfootjon bigfootjon requested a review from digantdesai as a code owner May 8, 2026 23:21
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19426

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 8 New Failures

As of commit 488505e with merge base 93b764e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414871.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Arm backend Buck build definitions to use the fbcode_target wrapper macro, consistent with build-file migration from TARGETS-style definitions toward BUCK-named build files.

Changes:

  • Add build_file_migration.bzl loads for fbcode_target/non_fbcode_target in two Arm BUCK files.
  • Wrap existing runtime.python_library targets with fbcode_target(_kind = runtime.python_library, ...) without changing target attributes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backends/arm/operator_support/BUCK Wraps the operator_support Python library target with fbcode_target for build-file migration compatibility.
backends/arm/debug/BUCK Wraps the schema Python library target with fbcode_target for build-file migration compatibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…0) (#19426)

Summary: Pull Request resolved: #19426

Reviewed By: bigfootjon

Differential Revision: D104414871
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: 7455922743067832490) Rename build files from TARGETS to BUCK (group ID: 7455922743067832490) (#19426) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104414871 branch from db58d88 to 488505e Compare May 9, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants