Skip to content

Rename build files from TARGETS to BUCK (group ID: -7288301333183062993) (#19425)#19425

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414850
Open

Rename build files from TARGETS to BUCK (group ID: -7288301333183062993) (#19425)#19425
bigfootjon wants to merge 1 commit intomainfrom
export-D104414850

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026 •
edited by meta-codesync Bot
Loading

Summary: Pull Request resolved: #19425

Reviewed By: bigfootjon

Differential Revision: D104414850

Copilot AI review requested due to automatic review settings May 8, 2026 23:21
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19425

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414850.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates ExecuTorch EXIR Buck build definitions from TARGETS files to BUCK files, aligning these directories with the expected build-file naming while preserving the existing target graph via fbcode_target wrappers.

Changes:

  • Moved exir/tests Buck targets from TARGETS into BUCK using fbcode_target.
  • Moved exir/emit Buck targets from TARGETS into BUCK using fbcode_target.
  • Updated exir/dialects/test/BUCK to wrap the unittest target with fbcode_target.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
exir/tests/TARGETS Removed in favor of exir/tests/BUCK.
exir/tests/BUCK Added migrated targets previously defined in exir/tests/TARGETS.
exir/emit/TARGETS Removed in favor of exir/emit/BUCK.
exir/emit/BUCK Added migrated targets previously defined in exir/emit/TARGETS.
exir/dialects/test/BUCK Wrapped existing unittest target with fbcode_target for migration consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread exir/tests/BUCK
@@ -1,4 +1,513 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
oncall("executorch")
# add this empty BUCK file to unblock landing. Without this, we get land error:
Comment thread exir/emit/BUCK
@@ -1,4 +1,45 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
oncall("executorch")
# add this empty BUCK file to unblock landing. Without this, we get land error:
@meta-codesync
Rename build files from TARGETS to BUCK (group ID: -72883013331830629…
6414aae 
…93) (#19425)

Summary: Pull Request resolved: #19425

Reviewed By: bigfootjon

Differential Revision: D104414850
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: -7288301333183062993) Rename build files from TARGETS to BUCK (group ID: -7288301333183062993) (#19425) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104414850 branch from 850c3d8 to 6414aae Compare May 9, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigfootjon