Skip to content

Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) (#19422)#19422

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414913
Open

Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) (#19422)#19422
bigfootjon wants to merge 1 commit intomainfrom
export-D104414913

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19422

Reviewed By: bigfootjon

Differential Revision: D104414913

Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@bigfootjon bigfootjon requested a review from Gasoonjia as a code owner May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19422

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 10c494e with merge base 4413a5c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414913.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames Buck build definition files from TARGETS to BUCK in a couple of devtools areas, using fbcode_target / non_fbcode_target wrappers to keep fbcode vs xplat definitions gated appropriately.

Changes:

  • Remove TARGETS files and add equivalent BUCK files.
  • Wrap migrated target definitions with fbcode_target / non_fbcode_target.
  • Merge an fbcode-only runtime.python_library target into the new BUCK for bundled program schema.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
devtools/etdump/data_sinks/tests/TARGETS Deleted in favor of BUCK migration.
devtools/etdump/data_sinks/tests/BUCK New BUCK file for data_sinks tests, currently only gated for fbcode.
devtools/bundled_program/schema/TARGETS Deleted after merging targets into BUCK.
devtools/bundled_program/schema/BUCK BUCK now contains both non-fbcode (xplat) and fbcode-gated targets after migration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


oncall("executorch")

fbcode_target(_kind = define_common_targets,)
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
oncall("executorch")
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.
# targets.bzl. This file can contain fbcode-only targets.

load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load(":targets.bzl", "define_common_targets")
…1) (#19422)

Summary: Pull Request resolved: #19422

Reviewed By: bigfootjon

Differential Revision: D104414913
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) (#19422) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104414913 branch from 300af5a to 10c494e Compare May 9, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants