Rename build files from TARGETS to BUCK (group ID: 778308238385783554)#19421
Rename build files from TARGETS to BUCK (group ID: 778308238385783554)#19421bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104415414
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19421
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Pending, 1 Unclassified FailureAs of commit 510393c with merge base 9889c7c ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415414. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR migrates Buck build definitions under test/ from TARGETS files into BUCK files, using fbcode_target / non_fbcode_target wrappers to preserve fbcode vs xplat behavior while unblocking builds that require BUCK presence.
Changes:
- Remove
test/TARGETSandtest/end2end/TARGETS. - Merge the removed
TARGETSdefinitions intotest/BUCKandtest/end2end/BUCKusingbuild_file_migration.bzlwrappers. - Keep
oncall("executorch")and@noautodepsmarkers in the migrated BUCK files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/TARGETS | Deleted; targets moved into test/BUCK. |
| test/end2end/TARGETS | Deleted; targets moved into test/end2end/BUCK. |
| test/end2end/BUCK | Now contains migrated fbcode-only Python targets wrapped with fbcode_target. |
| test/BUCK | Now calls define_common_targets via fbcode_target/non_fbcode_target to replace the removed TARGETS file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # @noautodeps | ||
| # add this empty BUCK file to unblock landing. Without this, we get land error like: | ||
| # "No build file at xplat/executorch/exir/BUCK when resolving target fbsource//xplat/executorch/exir:." | ||
|
|
||
| oncall("executorch") | ||
|
|
||
| # !!!! fbcode/executorch/test/end2end/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! | ||
|
|
||
| # @noautodeps |
| @@ -1,5 +1,103 @@ | |||
| load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") | |||
| load(":targets.bzl", "define_common_targets") | ||
|
|
||
|
|
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. | ||
|
|
Reviewed By: bigfootjon
Differential Revision: D104415414