Skip to content

Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) (#19418)#19418

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415471
Open

Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) (#19418)#19418
bigfootjon wants to merge 1 commit intomainfrom
export-D104415471

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19418

Reviewed By: bigfootjon

Differential Revision: D104415471

Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19418

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 1 Unrelated Failure

As of commit a164395 with merge base 93b764e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415471.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames/merges fbcode TARGETS build definitions into BUCK files for several ExecuTorch runtime/kernel directories, using fbcode_target/non_fbcode_target wrappers to keep fbcode vs xplat behavior separated within a single build file.

Changes:

  • Convert kernels/prim_ops, kernels/portable/test, and kernels/portable/cpu/util/test from TARGETS to BUCK by merging definitions and adding fbcode_target/non_fbcode_target wrappers.
  • Update runtime/BUCK to wrap the Python library target with fbcode_target.
  • Remove the now-redundant TARGETS files in the affected directories.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
runtime/BUCK Wraps the runtime python_library with fbcode_target as part of build file migration.
kernels/prim_ops/TARGETS Removes legacy TARGETS entrypoint now merged into BUCK.
kernels/prim_ops/BUCK Adds migration wrappers and incorporates former fbcode TARGETS behavior.
kernels/portable/test/TARGETS Removes legacy TARGETS entrypoint now merged into BUCK.
kernels/portable/test/BUCK Adds migration wrappers and moves aot_ops_test_lib under fbcode_target.
kernels/portable/cpu/util/test/TARGETS Removes legacy TARGETS entrypoint now merged into BUCK.
kernels/portable/cpu/util/test/BUCK Adds migration wrappers and incorporates former fbcode TARGETS behavior.
Comments suppressed due to low confidence (1)

runtime/BUCK:6

  • non_fbcode_target is loaded here but never referenced in this BUCK file. If the target is intended to be fbcode-only, drop the unused symbol from the load(...) to avoid Buck/bucklint unused-load failures; otherwise wrap an appropriate target with non_fbcode_target as well.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…0) (#19418)

Summary: Pull Request resolved: #19418

Reviewed By: bigfootjon

Differential Revision: D104415471
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) (#19418) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104415471 branch from 3f94ad1 to a164395 Compare May 9, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants