Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) (#19418)#19418
Rename build files from TARGETS to BUCK (group ID: 6312195356069443730) (#19418)#19418bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19418
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 1 Unrelated FailureAs of commit a164395 with merge base 93b764e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415471. |
There was a problem hiding this comment.
Pull request overview
Renames/merges fbcode TARGETS build definitions into BUCK files for several ExecuTorch runtime/kernel directories, using fbcode_target/non_fbcode_target wrappers to keep fbcode vs xplat behavior separated within a single build file.
Changes:
- Convert
kernels/prim_ops,kernels/portable/test, andkernels/portable/cpu/util/testfromTARGETStoBUCKby merging definitions and addingfbcode_target/non_fbcode_targetwrappers. - Update
runtime/BUCKto wrap the Python library target withfbcode_target. - Remove the now-redundant
TARGETSfiles in the affected directories.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/BUCK | Wraps the runtime python_library with fbcode_target as part of build file migration. |
| kernels/prim_ops/TARGETS | Removes legacy TARGETS entrypoint now merged into BUCK. |
| kernels/prim_ops/BUCK | Adds migration wrappers and incorporates former fbcode TARGETS behavior. |
| kernels/portable/test/TARGETS | Removes legacy TARGETS entrypoint now merged into BUCK. |
| kernels/portable/test/BUCK | Adds migration wrappers and moves aot_ops_test_lib under fbcode_target. |
| kernels/portable/cpu/util/test/TARGETS | Removes legacy TARGETS entrypoint now merged into BUCK. |
| kernels/portable/cpu/util/test/BUCK | Adds migration wrappers and incorporates former fbcode TARGETS behavior. |
Comments suppressed due to low confidence (1)
runtime/BUCK:6
non_fbcode_targetis loaded here but never referenced in this BUCK file. If the target is intended to be fbcode-only, drop the unused symbol from theload(...)to avoid Buck/bucklint unused-load failures; otherwise wrap an appropriate target withnon_fbcode_targetas well.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3f94ad1 to
a164395
Compare
Summary: Pull Request resolved: #19418
Reviewed By: bigfootjon
Differential Revision: D104415471