Skip to content

Rename build files from TARGETS to BUCK (group ID: -6034157572315752544)#19417

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414922
Open

Rename build files from TARGETS to BUCK (group ID: -6034157572315752544)#19417
bigfootjon wants to merge 1 commit intomainfrom
export-D104414922

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

Reviewed By: bigfootjon

Differential Revision: D104414922

Reviewed By: bigfootjon

Differential Revision: D104414922
Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@bigfootjon bigfootjon requested a review from Gasoonjia as a code owner May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19417

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 3c1d9ba with merge base 9889c7c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414922.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ExecuTorch devtools Buck build files as part of the “TARGETS → BUCK” migration, switching rule invocations to the fbcode_target wrapper used during build-file migration.

Changes:

  • Add build_file_migration.bzl loads and wrap runtime.python_* targets with fbcode_target in inspector build files.
  • Update devtools/etdump/tests/BUCK to use fbcode_target wrappers and keep unit tests defined in the BUCK file.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
devtools/inspector/numerical_comparator/BUCK Wrap Python library targets with fbcode_target for migration.
devtools/inspector/BUCK Wrap inspector Python library/binary targets with fbcode_target for migration.
devtools/etdump/tests/BUCK Wrap test targets with migration wrapper; currently wraps define_common_targets in a way that likely breaks the intended pattern.
Comments suppressed due to low confidence (4)

devtools/etdump/tests/BUCK:9

  • define_common_targets is a macro that defines multiple build targets and is expected to be called directly from the BUCK/TARGETS/BUILD file (see runtime_wrapper.bzl docs). Wrapping it in fbcode_target is likely incorrect (and may fail if fbcode_target expects a name kwarg). Call define_common_targets() directly here instead.
    devtools/inspector/BUCK:3
  • non_fbcode_target is loaded but not used in this file. Consider removing it from the load() to avoid unused-symbol lint issues and keep the BUCK file minimal.
    devtools/inspector/numerical_comparator/BUCK:3
  • non_fbcode_target is loaded but not used in this file. Consider removing it from the load() to avoid unused-symbol lint issues and keep the BUCK file minimal.
    devtools/etdump/tests/BUCK:4
  • non_fbcode_target is loaded but not used in this file. Consider removing it from the load() to avoid unused-symbol lint issues and keep the BUCK file minimal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants