Rename build files from TARGETS to BUCK (group ID: -6034157572315752544)#19417
Rename build files from TARGETS to BUCK (group ID: -6034157572315752544)#19417bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104414922
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19417
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 3c1d9ba with merge base 9889c7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414922. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR updates ExecuTorch devtools Buck build files as part of the “TARGETS → BUCK” migration, switching rule invocations to the fbcode_target wrapper used during build-file migration.
Changes:
- Add
build_file_migration.bzlloads and wrapruntime.python_*targets withfbcode_targetin inspector build files. - Update
devtools/etdump/tests/BUCKto usefbcode_targetwrappers and keep unit tests defined in the BUCK file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| devtools/inspector/numerical_comparator/BUCK | Wrap Python library targets with fbcode_target for migration. |
| devtools/inspector/BUCK | Wrap inspector Python library/binary targets with fbcode_target for migration. |
| devtools/etdump/tests/BUCK | Wrap test targets with migration wrapper; currently wraps define_common_targets in a way that likely breaks the intended pattern. |
Comments suppressed due to low confidence (4)
devtools/etdump/tests/BUCK:9
define_common_targetsis a macro that defines multiple build targets and is expected to be called directly from the BUCK/TARGETS/BUILD file (seeruntime_wrapper.bzldocs). Wrapping it infbcode_targetis likely incorrect (and may fail iffbcode_targetexpects anamekwarg). Calldefine_common_targets()directly here instead.
devtools/inspector/BUCK:3non_fbcode_targetis loaded but not used in this file. Consider removing it from theload()to avoid unused-symbol lint issues and keep the BUCK file minimal.
devtools/inspector/numerical_comparator/BUCK:3non_fbcode_targetis loaded but not used in this file. Consider removing it from theload()to avoid unused-symbol lint issues and keep the BUCK file minimal.
devtools/etdump/tests/BUCK:4non_fbcode_targetis loaded but not used in this file. Consider removing it from theload()to avoid unused-symbol lint issues and keep the BUCK file minimal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviewed By: bigfootjon
Differential Revision: D104414922